mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 37487: Fixed flaky HTTPTest.NestedGet test.
Date Fri, 14 Aug 2015 17:30:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37487/#review95453
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On Aug. 14, 2015, 5:23 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37487/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2015, 5:23 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Ben Mahler.
> 
> 
> Bugs: MESOS-3262
>     https://issues.apache.org/jira/browse/MESOS-3262
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Turns out the test was directly calling methods on HttpProcess instead of dispatching
to it. Added routes for "/a/b/c" and "/a" handlers in initialize like we did with all the
other handlers.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/http_tests.cpp 7351fa44e69743ab82e9cada7ba7f797a6899bab

> 
> Diff: https://reviews.apache.org/r/37487/diff/
> 
> 
> Testing
> -------
> 
> Ran the test in a loop 10K times.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message