mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 37457: Add --ip_discovery_command to Agent.
Date Fri, 14 Aug 2015 03:55:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37457/#review95377
-----------------------------------------------------------


Patch looks great!

Reviews applied: [36978, 36979, 37457]

All tests passed.

- Mesos ReviewBot


On Aug. 14, 2015, 12:21 a.m., Marco Massenzio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37457/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2015, 12:21 a.m.)
> 
> 
> Review request for mesos, Cody Maloney and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Similarly to the Master, we want to enable the Agent too to be initialized
> with an IP address that is "discovered" by an arbitrary script.
> 
> This is particularly useful for Mesos deployments on public (or private) clouds
> where DNS resolution is either limited or not feasible.
> 
> Jira: MESOS-3154
> 
> 
> Diffs
> -----
> 
>   src/slave/main.cpp 8008430e98773d8be9ba5ac6385cffb2e351932a 
> 
> Diff: https://reviews.apache.org/r/37457/diff/
> 
> 
> Testing
> -------
> 
> make check
> run `./bin/mesos-slave --ip_discovery_command=/.../discover-ip.py ...`
> and verified it binds to the expected address:
> ```
> I0813 17:18:24.871472 2046800640 main.cpp:272] Starting Mesos slave
> I0813 17:18:24.873610 292802560 slave.cpp:190] Slave started on 1)@192.168.33.1:5051
> I0813 17:18:24.873633 292802560 slave.cpp:191] Flags at startup: --appc_store_dir="/tmp/mesos/store/appc"
--authenticatee="crammd5" --container_disk_watch_interval="15secs" --containerizers="mesos"
--default_role="*" --disk_watch_interval="1mins" --docker="docker" --docker_kill_orphans="true"
--docker_remove_delay="6hrs" --docker_socket="/var/run/docker.sock" --docker_stop_timeout="0ns"
--enforce_container_disk_quota="false" --executor_registration_timeout="1mins" --executor_shutdown_grace_period="5secs"
--fetcher_cache_dir="/tmp/mesos/fetch" --fetcher_cache_size="2GB" --frameworks_home="" --gc_delay="1weeks"
--gc_disk_headroom="0.1" --hadoop_home="" --help="false" --initialize_driver_logging="true"
--ip_discovery_command="~/dev/discovery-ip.py" --isolation="posix/cpu,posix/mem" --launcher_dir="/Users/marco/dev/workspace/mesos/build/src"
--logbufsecs="0" --logging_level="INFO" --master="127.0.0.1:5050" --modules="libraries {
>   file: "/Users/marco/dev/workspace/modules/execute/build/Debug/libexecmod.so"
>   modules {
>     name: "com_mesosphere_mesos_RemoteExecutionAnonymous"
>   }
> }
> " --oversubscribed_resources_interval="15secs" --port="5051" --qos_correction_interval_min="0ns"
--quiet="false" --recover="reconnect" --recovery_timeout="15mins" --registration_backoff_factor="1secs"
--resource_monitoring_interval="1secs" --sandbox_directory="/mnt/mesos/sandbox" --strict="true"
--switch_user="true" --version="false" --work_dir="/tmp/slave"
> I0813 17:18:24.875107 292802560 slave.cpp:354] Slave resources: cpus(*):8; mem(*):15360;
disk(*):470858; ports(*):[31000-32000]
> I0813 17:18:24.881863 292802560 slave.cpp:384] Slave hostname: 192.168.33.1
> ...
> ```
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message