mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jojy Varghese" <j...@mesosphere.io>
Subject Re: Review Request 37427: Docker registry: adding TokenManager.
Date Thu, 13 Aug 2015 15:05:18 GMT


> On Aug. 13, 2015, 6:24 a.m., Lily Chen wrote:
> > src/slave/containerizer/provisioners/docker/token_manager.cpp, lines 37-46
> > <https://reviews.apache.org/r/37427/diff/2/?file=1039212#file1039212line37>
> >
> >     no need to put underscore in front of parameters being passed in

As per style docs, its an acceptable way to disambiguate.


> On Aug. 13, 2015, 6:24 a.m., Lily Chen wrote:
> > src/tests/containerizer/docker_containerizer_tests.cpp, line 2998
> > <https://reviews.apache.org/r/37427/diff/2/?file=1039213#file1039213line2998>
> >
> >     DockerContainerizerTest tests the Docker Containerizer. The TokenManager is
a component of the Mesos Containerizer, and would therefore be a part of a Docker provisioner
test file.

I understand. Since other part of proviosioner feature is being worked on in parallel, I have
put these tests in this file, as I didnt see a separate file for provisioner  tests. I have
added a TODO in the test file to move these tests to the new file when it is dropped. Also,
these new tests are isolated from the already existing tests in the file.


- Jojy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37427/#review95238
-----------------------------------------------------------


On Aug. 13, 2015, 8:29 a.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37427/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2015, 8:29 a.m.)
> 
> 
> Review request for mesos, Lily Chen and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changes:
>   - Added Token implementation (RFC 7519).
>   - Added TokenManager implementation. This component keeps a cache of tokens
>   requested for any future requests.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 111aed92820689b12ee4073269ce34db7be30960 
>   src/slave/containerizer/provisioners/docker/token_manager.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/token_manager.cpp PRE-CREATION 
>   src/tests/containerizer/docker_containerizer_tests.cpp c8c27a64c06cf37bdaa5b474ea25bd2e971c8fea

> 
> Diff: https://reviews.apache.org/r/37427/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message