mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From José Guilherme Vanz <guilherme....@gmail.com>
Subject Re: Review Request 37268: Style checker checking for { on newline
Date Wed, 12 Aug 2015 21:29:31 GMT


> On Aug. 9, 2015, 11:28 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> > 
> > Reviews applied: [37266]
> > 
> > Failed command: ./support/apply-review.sh -n -r 37266
> > 
> > Error:
> >  2015-08-09 23:28:17 URL:https://reviews.apache.org/r/37266/diff/raw/ [8119/8119]
-> "37266.patch" [1]
> > Traceback (most recent call last):
> >   File "./support/jsonurl.py", line 25, in <module>
> >     print data
> > UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 3:
ordinal not in range(128)
> > Successfully applied: Style checker checking for { on newline
> > 
> > As requested in the issue MESOS-2578 the style checker now
> > verifies "{" on newline for class and methods declarations.
> > 
> > This commit contains the files changed in the mesos project
> > 
> > 
> > Review: https://reviews.apache.org/r/37266
> > fatal: empty ident name (for <guilherme.sft@gmail.com>) not allowed
> > Failed to commit patch

Solved. There is a issue with description with "


- José Guilherme


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/#review94684
-----------------------------------------------------------


On Aug. 12, 2015, 1:15 a.m., José Guilherme Vanz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37268/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2015, 1:15 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2578
>     https://issues.apache.org/jira/browse/MESOS-2578
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> As requested in the issue MESOS-2578 the style checker now
> verifies { on newline for class and methods declarations.
> 
> This commit contains the files changed in the stout project
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 30baa65837621a277cf9d1042a751bfe18004b05

> 
> Diff: https://reviews.apache.org/r/37268/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> José Guilherme Vanz
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message