mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "haosdent huang" <haosd...@gmail.com>
Subject Re: Review Request 37273: [2/3]Add CMake macro VsBuildCommand in libprocess.
Date Tue, 11 Aug 2015 17:25:01 GMT


> On Aug. 10, 2015, 6:42 p.m., Alex Clemmer wrote:
> > 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 55
> > <https://reviews.apache.org/r/37273/diff/2/?file=1036047#file1036047line55>
> >
> >     Sorry, maybe I'm a bit slow this morning -- but how are you running this? Windows
doesn't have the `patch` utility, right? How does this actually get patched on Windows?
> 
> haosdent huang wrote:
>     Oh, I have installed MinGW. So the we move it to github and download?
> 
> Alex Clemmer wrote:
>     Ah. We can't have a MinGW dependency at all, unfortunately. Could you please consider
rebasing this against my recent glog changes, where we download the tarball from GitHub?

Got it. Let me change download from github.


> On Aug. 10, 2015, 6:42 p.m., Alex Clemmer wrote:
> > 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 77
> > <https://reviews.apache.org/r/37273/diff/2/?file=1036047#file1036047line77>
> >
> >     So, why change the value to `TRUE` here? Is there some consequence of this,
or is it just clearer to you?
> >     
> >     (Also, if we want to go this way, it probably makes sense to change the `""`
we use in the `ExternalProject_Add` calls as well, just for consistency.)
> 
> haosdent huang wrote:
>     Hmm, because I find
>     
>     ```
>     set(GLOG_CONFIG_CMD  "")
>     ```
>     
>     the visual studio would still execute default configure step which requires CMakeLists.txt
.
>     
>     I still don't know why its behaivour would become this here.
> 
> Alex Clemmer wrote:
>     Interesting! What does it say on your machine. On my machine (I will have to confirm
this in a minute) I remember it saying that there is "no configure step" for glog. Do you
see something different?

LoL, I suck on this strange point in serveral hours and try possible ways to skip it. But
all of them are failed.
If I direct pass "" to ExternalProject_Add, it could skip the configuration step. But I set
"" to a variable and pass this variable as configuration step in ExternalProject_Add. It would
become try to use default CMake configuration step, which need CMakeLists.txt. I use message
to debug the variable and compare the variables with "", I am sure the variable is setted
to empty string.

My CMake version is 3.3; Visual studio version is 2015 community version; OS is win7; Project
code is in a independent disk.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37273/#review94776
-----------------------------------------------------------


On Aug. 10, 2015, 9:50 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37273/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 9:50 a.m.)
> 
> 
> Review request for mesos and Alex Clemmer.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add CMake macro VsBuildCommand in libprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 997cc0d0e316e316136d4746e50e9e292a82b36b

>   3rdparty/libprocess/3rdparty/glog-0.3.3.patch 76b8c0fe3b4615371e265bab713d62c896b7c3d6

>   3rdparty/libprocess/3rdparty/protobuf-2.5.0.patch PRE-CREATION 
>   3rdparty/libprocess/cmake/ProcessConfigure.cmake 12506a1369de005285268f895f365aba0c560f78

>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 9e4dcb83a8cc4e95a2a38573944f6b38e2eac76e

>   3rdparty/libprocess/cmake/macros/VsBuildCommand.bat PRE-CREATION 
>   3rdparty/libprocess/cmake/macros/VsBuildCommand.cmake PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37273/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message