mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 37304: Add authorization for http based schedulers
Date Mon, 10 Aug 2015 22:43:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37304/#review94819
-----------------------------------------------------------

Ship it!



src/master/master.cpp (line 1828)
<https://reviews.apache.org/r/37304/#comment149456>

    Is it possible to s/f/_subscribe/ or would the compiler barf?



src/master/master.cpp (line 1863)
<https://reviews.apache.org/r/37304/#comment149455>

    add a colon before the error message.



src/master/master.cpp (line 2094)
<https://reviews.apache.org/r/37304/#comment149457>

    ditto. can we rename 'f' to '_subscribe' ?


- Vinod Kone


On Aug. 10, 2015, 5 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37304/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 5 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 10cc100b1cf10aa7a8a9979a2562a9c5a9e55bd6 
>   src/master/master.cpp 08dd34d9d18f547c6e8d04caf9e39a2b3ffc5f63 
> 
> Diff: https://reviews.apache.org/r/37304/diff/
> 
> 
> Testing
> -------
> 
> make check + would add tests in separate patch
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message