mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <alexan...@mesosphere.io>
Subject Re: Review Request 37097: Fix 'Accept-Encoding' parsing
Date Thu, 06 Aug 2015 09:41:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37097/#review94386
-----------------------------------------------------------



3rdparty/libprocess/src/http.cpp (lines 133 - 138)
<https://reviews.apache.org/r/37097/#comment148962>

    Can you leave the RFC number here? I find it is a good practice even if it is repeatedly
used.



3rdparty/libprocess/src/http.cpp (lines 134 - 138)
<https://reviews.apache.org/r/37097/#comment148963>

    This paragraph doesn't seem to come from the RFC. Can you move it before the headline
or after the contents from the rfc?



3rdparty/libprocess/src/http.cpp (line 159)
<https://reviews.apache.org/r/37097/#comment148964>

    I don't think we use `cout` in libprocess but `VLOG` (check `decode` in this file).


- Alexander Rojas


On Aug. 5, 2015, 9 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37097/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2015, 9 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently parsing only compares the begining of the header making 'gzipbug' match with
candidate 'gzip'
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp b8d9300 
>   3rdparty/libprocess/src/http.cpp 4dcbd74 
>   3rdparty/libprocess/src/tests/encoder_tests.cpp 0032137 
> 
> Diff: https://reviews.apache.org/r/37097/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message