Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8FD361896E for ; Wed, 29 Jul 2015 19:30:30 +0000 (UTC) Received: (qmail 57867 invoked by uid 500); 29 Jul 2015 19:30:30 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 57841 invoked by uid 500); 29 Jul 2015 19:30:30 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 57827 invoked by uid 99); 29 Jul 2015 19:30:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Jul 2015 19:30:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 634FFD7747; Wed, 29 Jul 2015 19:30:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5780809736265148561==" MIME-Version: 1.0 Subject: Review Request 36919: Pulled out call validation. From: "Ben Mahler" To: "Anand Mazumdar" , "Vinod Kone" Cc: "Ben Mahler" , "mesos" Date: Wed, 29 Jul 2015 19:30:29 -0000 Message-ID: <20150729193029.1540.13553@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36919/ X-Sender: "Ben Mahler" Reply-To: "Ben Mahler" X-ReviewRequest-Repository: mesos --===============5780809736265148561== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36919/ ----------------------------------------------------------- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos Description ------- Call validation was duplicated across scheduler.cpp and the master. With the http api, we will also want an easy way to validate and drop calls that are coming in to the master. Diffs ----- src/master/master.hpp 2331173fb9aeca77227fb09b899cb123eb205b4b src/master/master.cpp c584cb9f5aeb6806657059a3204ce1c680d4214a src/master/validation.hpp 469d6f56c3de28a34177124aae81ce24cb4ad160 src/master/validation.cpp 9d128aa1b349b018b8e4a1916434d848761ca051 src/scheduler/scheduler.cpp 6887ed109a4b7342a460fff2ebbe1d98ff3e9092 Diff: https://reviews.apache.org/r/36919/diff/ Testing ------- make check This also makes it easier to unit test this validation going forward. Thanks, Ben Mahler --===============5780809736265148561==--