Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 49C9818147 for ; Wed, 29 Jul 2015 16:04:59 +0000 (UTC) Received: (qmail 99948 invoked by uid 500); 29 Jul 2015 16:04:42 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 99940 invoked by uid 500); 29 Jul 2015 16:04:42 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 99575 invoked by uid 99); 29 Jul 2015 16:04:42 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Jul 2015 16:04:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9F5ABD75B5; Wed, 29 Jul 2015 16:04:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1369648863126875513==" MIME-Version: 1.0 Subject: Re: Review Request 36429: Add filesystem/linux isolator for persistent volumes. From: "James DeFelice" To: "Vinod Kone" , "Timothy Chen" , "Jie Yu" Cc: "mesos" , "James DeFelice" , "Ian Downes" Date: Wed, 29 Jul 2015 16:04:41 -0000 Message-ID: <20150729160441.1539.53374@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "James DeFelice" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36429/ X-Sender: "James DeFelice" References: <20150712044624.1572.25304@reviews.apache.org> In-Reply-To: <20150712044624.1572.25304@reviews.apache.org> Reply-To: "James DeFelice" X-ReviewRequest-Repository: mesos --===============1369648863126875513== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36429/#review93457 ----------------------------------------------------------- src/slave/containerizer/isolators/filesystem/linux.cpp (line 238) why MS_SHARED (bidirectional) vs MS_SLAVE (one-way)? MS_SLAVE would probably give better isolation to the host mount-ns. MS_SHARED would probably be better for a use case that I have in mind (doc'd in MESOS-349), especially since cleanup() here does GC on mount points that are children of the sandbox. - James DeFelice On July 12, 2015, 4:46 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36429/ > ----------------------------------------------------------- > > (Updated July 12, 2015, 4:46 a.m.) > > > Review request for mesos, Jie Yu, Timothy Chen, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Moved filesystem/linux from review https://reviews.apache.org/r/34135/ > > > Diffs > ----- > > src/Makefile.am e5b5d36f0ac160e5a3a9fdc50b31c060a413ce2c > src/slave/containerizer/isolators/filesystem/linux.hpp PRE-CREATION > src/slave/containerizer/isolators/filesystem/linux.cpp PRE-CREATION > src/slave/containerizer/mesos/containerizer.cpp 47d146125dfd4ea909e7ec9d94f41cfa11d035e5 > > Diff: https://reviews.apache.org/r/36429/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > > --===============1369648863126875513==--