Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6B5E11840D for ; Mon, 27 Jul 2015 17:56:50 +0000 (UTC) Received: (qmail 96655 invoked by uid 500); 27 Jul 2015 17:56:50 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 96632 invoked by uid 500); 27 Jul 2015 17:56:50 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 96615 invoked by uid 99); 27 Jul 2015 17:56:50 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Jul 2015 17:56:50 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 85143D5D91; Mon, 27 Jul 2015 17:56:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6152118918649045606==" MIME-Version: 1.0 Subject: Re: Review Request 36830: Libprocess: Introduced configurable `UNIMPLEMENTED` macro. From: "Joseph Wu" To: "Artem Harutyunyan" , "Benjamin Hindman" , "Joseph Wu" , "Michael Park" Cc: "Joris Van Remoortere" , "mesos" Date: Mon, 27 Jul 2015 17:56:49 -0000 Message-ID: <20150727175649.28760.93165@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Joseph Wu" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36830/ X-Sender: "Joseph Wu" References: <20150727071749.28760.9592@reviews.apache.org> In-Reply-To: <20150727071749.28760.9592@reviews.apache.org> Reply-To: "Joseph Wu" X-ReviewRequest-Repository: mesos --===============6152118918649045606== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36830/#review93145 ----------------------------------------------------------- Ship it! Ship It! - Joseph Wu On July 27, 2015, 12:17 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36830/ > ----------------------------------------------------------- > > (Updated July 27, 2015, 12:17 a.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and Michael Park. > > > Bugs: MESOS-3122 > https://issues.apache.org/jira/browse/MESOS-3122 > > > Repository: mesos > > > Description > ------- > > use --enable-static-unimplemented to get compile time errors as opposed > to runtime errors. > > > Diffs > ----- > > 3rdparty/libprocess/configure.ac 7d1221bd5ddfc4fa816b0bbea0be5c6b20000cbb > > Diff: https://reviews.apache.org/r/36830/diff/ > > > Testing > ------- > > created a function with an `UNIMPLEMENTED()` body and verified the runtime error occured when configured by default, and a compile-time error ocurred when configured with `--enable-static-unimplemented` > > > Thanks, > > Joris Van Remoortere > > --===============6152118918649045606==--