Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BF0FC18F27 for ; Fri, 24 Jul 2015 17:46:43 +0000 (UTC) Received: (qmail 62478 invoked by uid 500); 24 Jul 2015 17:46:43 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 62453 invoked by uid 500); 24 Jul 2015 17:46:43 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 62435 invoked by uid 99); 24 Jul 2015 17:46:43 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Jul 2015 17:46:43 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0A1D5D5D7D; Fri, 24 Jul 2015 17:46:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8928507115084892028==" MIME-Version: 1.0 Subject: Re: Review Request 36757: Added https support. From: "Jojy Varghese" To: "Joris Van Remoortere" , "Timothy Chen" Cc: "Anand Mazumdar" , "Jojy Varghese" , "mesos" Date: Fri, 24 Jul 2015 17:46:43 -0000 Message-ID: <20150724174643.1578.87685@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jojy Varghese" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36757/ X-Sender: "Jojy Varghese" References: <20150724155803.1579.82766@reviews.apache.org> In-Reply-To: <20150724155803.1579.82766@reviews.apache.org> Reply-To: "Jojy Varghese" X-ReviewRequest-Repository: mesos --===============8928507115084892028== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On July 24, 2015, 3:58 p.m., Anand Mazumdar wrote: > > 3rdparty/libprocess/src/tests/ssl_tests.cpp, line 989 > > > > > > AWAIT_EXPECT_RESPONSE_STATUS_EQ(OK().status, response); The pattern "ASSERT_EQ(http::statuses[200], response.get().status)" is the one adopted in http_tests.cpp. Not sure if I want to have a new pattern for https tests. > On July 24, 2015, 3:58 p.m., Anand Mazumdar wrote: > > 3rdparty/libprocess/src/tests/ssl_tests.cpp, line 1015 > > > > > > s/{}/None() > > s/payload/None() > > > > You should be able to do without setting headers and body here. It will work but the test here is for having "some" payload and https not crapping out for actual POST data. - Jojy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36757/#review92921 ----------------------------------------------------------- On July 24, 2015, 3:23 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36757/ > ----------------------------------------------------------- > > (Updated July 24, 2015, 3:23 p.m.) > > > Review request for mesos, Joris Van Remoortere and Timothy Chen. > > > Bugs: MESOS-3093 > https://issues.apache.org/jira/browse/MESOS-3093 > > > Repository: mesos > > > Description > ------- > > Current http implementation lacks a https interface. This change exposes > SSL socket for "https" URL scheme. > > JIRA: MESOS-3093 > > > Diffs > ----- > > 3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f > 3rdparty/libprocess/src/tests/ssl_tests.cpp 2fe50601615b0bee57bd3e05dc9c932f93ca7477 > > Diff: https://reviews.apache.org/r/36757/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jojy Varghese > > --===============8928507115084892028==--