Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1CECC18C55 for ; Thu, 23 Jul 2015 22:16:12 +0000 (UTC) Received: (qmail 22303 invoked by uid 500); 23 Jul 2015 22:16:12 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 22281 invoked by uid 500); 23 Jul 2015 22:16:12 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 22268 invoked by uid 99); 23 Jul 2015 22:16:11 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Jul 2015 22:16:11 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 714C1D5894; Thu, 23 Jul 2015 22:16:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7560672477793798689==" MIME-Version: 1.0 Subject: Re: Review Request 36718: Converted Limitation and ExecutorRunState structs into protobufs. From: "Kapil Arya" To: "Benjamin Hindman" , "Jie Yu" Cc: "Mesos ReviewBot" , "mesos" Date: Thu, 23 Jul 2015 22:16:11 -0000 Message-ID: <20150723221611.1578.32352@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Kapil Arya" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36718/ X-Sender: "Kapil Arya" References: <20150723033736.10542.30866@reviews.apache.org> In-Reply-To: <20150723033736.10542.30866@reviews.apache.org> Reply-To: "Kapil Arya" X-ReviewRequest-Repository: mesos --===============7560672477793798689== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36718/ ----------------------------------------------------------- (Updated July 23, 2015, 6:16 p.m.) Review request for mesos, Benjamin Hindman and Jie Yu. Changes ------- addressed Jie's comments Bugs: MESOS-3115 https://issues.apache.org/jira/browse/MESOS-3115 Repository: mesos Description ------- Protobufs are preferred over C structs for public API. Diffs (updated) ----- include/mesos/slave/isolator.hpp 85e38f5e4aa66527f1756fa259b93389f45028b3 include/mesos/slave/isolator.proto PRE-CREATION src/Makefile.am 489ddb424b342635c3dbc4d14ff5d69ce76a237b src/common/protobuf_utils.hpp 2e827a0923de83d5cf853a12435b451cc7c55891 src/common/protobuf_utils.cpp e0f82b53f5e106bbf4e21d6ac946df0fae821882 src/exec/exec.cpp a1ae074b962d8e93ab7776bd624389857da486f3 src/slave/containerizer/isolator.cpp 278824c0cb662bb09150e8cb5a72dafef034e6fb src/slave/containerizer/isolators/cgroups/cpushare.hpp 2118c97d4f3d2e58fab62c6e99d5bec6f4df8bbd src/slave/containerizer/isolators/cgroups/cpushare.cpp 750bef947c11eb55236ac46109b9dd97e62b453d src/slave/containerizer/isolators/cgroups/mem.hpp dc752014236b69d34c6b33a06fc00580780b0b4c src/slave/containerizer/isolators/cgroups/mem.cpp b0e343fdc7088b2895d5dc8bb416dbcbf241cae5 src/slave/containerizer/isolators/cgroups/perf_event.hpp 560cd0359a2795a937335efa30dc380a60fcb540 src/slave/containerizer/isolators/cgroups/perf_event.cpp 512df3be7fdf6bac22ad4122f54a21d9986a1a6a src/slave/containerizer/isolators/filesystem/posix.hpp 16ba26f4f5b515acbeb3c4d514d4eecf2f277df8 src/slave/containerizer/isolators/filesystem/posix.cpp 1904279c92ef00ef931c909b4bb15bef89a4fc59 src/slave/containerizer/isolators/filesystem/shared.hpp 4d7d9a9e310cb636dc4983de86e9e4c9321104ea src/slave/containerizer/isolators/filesystem/shared.cpp 24f30746be7b5be95a4d8f442a3a5464d1f0f2a0 src/slave/containerizer/isolators/namespaces/pid.hpp 9cda3fd418d0f0df4d12ed1367da277b81866103 src/slave/containerizer/isolators/namespaces/pid.cpp 5de0791a835d725b7c7aae1ba585a94cff9372f1 src/slave/containerizer/isolators/network/port_mapping.hpp 6b5cf62838637e9759935f9edf0c152a035005fe src/slave/containerizer/isolators/network/port_mapping.cpp a7757f2a51f04da27645074f048722c22a2be752 src/slave/containerizer/isolators/posix.hpp 271061ef97aea96bb816982e530c84554d4b08d8 src/slave/containerizer/isolators/posix/disk.hpp 5dfa815edaee9b17c19ae2a7491e63c545c8ab1f src/slave/containerizer/isolators/posix/disk.cpp b2f995cba36b1399db48af1de49d76c607f80abd src/slave/containerizer/launcher.cpp 24df1ca5f7407062f9e7b4bfa18f2cae5c72e140 src/slave/containerizer/linux_launcher.cpp 790e392645dd62e74b03ff0771f6bf0e9efeb622 src/slave/containerizer/mesos/containerizer.hpp f6c580d1b629ee799977cc8824f337764d893c5f src/slave/containerizer/mesos/containerizer.cpp 609620c4322e41562597ee682b311cd320bca6d2 src/tests/containerizer_tests.cpp 29114e7322b9239fb3e5f4921f542bd991fd426e src/tests/isolator.hpp fd6aec74edf49153d31b559d56e8e06c15836f68 Diff: https://reviews.apache.org/r/36718/diff/ Testing ------- make check Thanks, Kapil Arya --===============7560672477793798689==--