Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9F48C18BA6 for ; Thu, 23 Jul 2015 14:52:39 +0000 (UTC) Received: (qmail 80870 invoked by uid 500); 23 Jul 2015 14:52:17 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 80839 invoked by uid 500); 23 Jul 2015 14:52:17 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 80813 invoked by uid 99); 23 Jul 2015 14:52:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Jul 2015 14:52:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1513CD5641; Thu, 23 Jul 2015 14:52:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3782145410044715933==" MIME-Version: 1.0 Subject: Re: Review Request 36501: MESOS-3023 From: "Bernd Mathiske" To: "Klaus Ma" , "mesos" , "Bernd Mathiske" , "haosdent huang" Date: Thu, 23 Jul 2015 14:52:17 -0000 Message-ID: <20150723145217.1578.11385@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Bernd Mathiske" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36501/ X-Sender: "Bernd Mathiske" References: <20150720164258.10542.81570@reviews.apache.org> In-Reply-To: <20150720164258.10542.81570@reviews.apache.org> Reply-To: "Bernd Mathiske" X-ReviewRequest-Repository: mesos --===============3782145410044715933== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On July 20, 2015, 9:42 a.m., haosdent huang wrote: > > src/tests/fetcher_tests.cpp, line 297 > > > > > > According https://github.com/apache/mesos/blob/master/docs/mesos-c%2B%2B-style-guide.md#function-definitioninvocation You indent is not correct here. Maybe need change to like this > > > > ``` > > process::http::URL url( > > "http", > > process.self().address.ip, > > process.self().address.port, > > "/help"); > > ``` > > > > But I perfer chang it like this > > ``` > > const network::Address& address = process.self().address; > > process::http::URL url("http", address.ip, address.port, "/help"); > > ``` > > > > Or add `using URL` like this > > ``` > > using process::Future; > > > > using process::http::URL; (Left a blank below and after process::Future) > > ``` > > > > and then > > ``` > > const network::Address& address = process.self().address; > > URL url("http", address.ip, address.port, "/help"); > > ``` I agree. Thanks, haosdent! - Bernd ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/#review92270 ----------------------------------------------------------- On July 18, 2015, 2:47 a.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36501/ > ----------------------------------------------------------- > > (Updated July 18, 2015, 2:47 a.m.) > > > Review request for mesos. > > > Bugs: MESOS-3023 > https://issues.apache.org/jira/browse/MESOS-3023 > > > Repository: mesos > > > Description > ------- > > Fix for MESOS-3023 (Factoring out the pattern for URL generation) > > > Diffs > ----- > > src/tests/fetcher_tests.cpp ae10c42 > > Diff: https://reviews.apache.org/r/36501/diff/ > > > Testing > ------- > > 1. Build successfully in Linux > 2. Test passed by src/mesos-tests --gtest_filter=FetcherTest.OSNetUriTest > > > Thanks, > > Klaus Ma > > --===============3782145410044715933==--