Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6CA4917FAB for ; Wed, 22 Jul 2015 23:50:30 +0000 (UTC) Received: (qmail 76851 invoked by uid 500); 22 Jul 2015 23:50:21 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 76828 invoked by uid 500); 22 Jul 2015 23:50:20 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 76811 invoked by uid 99); 22 Jul 2015 23:50:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Jul 2015 23:50:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B81D3BECAD; Wed, 22 Jul 2015 23:50:18 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3558481356436732544==" MIME-Version: 1.0 Subject: Re: Review Request 36620: WIP Added Non-Freezeer Task Killer. From: "Timothy Chen" To: "Timothy Chen" Cc: "Joerg Schad" , "mesos" Date: Wed, 22 Jul 2015 23:50:18 -0000 Message-ID: <20150722235018.10541.34576@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Timothy Chen" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36620/ X-Sender: "Timothy Chen" References: <20150722100432.10541.44236@reviews.apache.org> In-Reply-To: <20150722100432.10541.44236@reviews.apache.org> Reply-To: "Timothy Chen" X-ReviewRequest-Repository: mesos --===============3558481356436732544== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review92683 ----------------------------------------------------------- src/linux/cgroups.cpp (line 1627) I think it's good to also describe what the killer does and why it needs to recursively kill. src/linux/cgroups.cpp (line 1859) I don't think this log is necessary, at very least VLOG(1) - Timothy Chen On July 22, 2015, 10:04 a.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36620/ > ----------------------------------------------------------- > > (Updated July 22, 2015, 10:04 a.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-3086 > https://issues.apache.org/jira/browse/MESOS-3086 > > > Repository: mesos > > > Description > ------- > > WIP Added Non-Freezeer Task Killer. > > > Diffs > ----- > > src/linux/cgroups.cpp e062fcbd56315f11882fe0ccb615c490dd719934 > > Diff: https://reviews.apache.org/r/36620/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Joerg Schad > > --===============3558481356436732544==--