Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6F544181A8 for ; Wed, 22 Jul 2015 07:33:21 +0000 (UTC) Received: (qmail 65546 invoked by uid 500); 22 Jul 2015 07:33:21 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 65523 invoked by uid 500); 22 Jul 2015 07:33:21 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 65507 invoked by uid 99); 22 Jul 2015 07:33:21 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Jul 2015 07:33:21 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4F5991CBF4F; Wed, 22 Jul 2015 07:33:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6522913486938993069==" MIME-Version: 1.0 Subject: Re: Review Request 36425: Enabling IP Discovery script From: "Marco Massenzio" To: "Benjamin Hindman" , "Cody Maloney" Cc: "mesos" , "Anand Mazumdar" , "Marco Massenzio" , "Mesos ReviewBot" Date: Wed, 22 Jul 2015 07:33:19 -0000 Message-ID: <20150722073319.10541.50812@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Marco Massenzio" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36425/ X-Sender: "Marco Massenzio" References: <20150721164706.10542.85650@reviews.apache.org> In-Reply-To: <20150721164706.10542.85650@reviews.apache.org> Reply-To: "Marco Massenzio" X-ReviewRequest-Repository: mesos --===============6522913486938993069== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36425/ ----------------------------------------------------------- (Updated July 22, 2015, 7:33 a.m.) Review request for mesos, Benjamin Hindman and Cody Maloney. Bugs: MESOS-2902 https://issues.apache.org/jira/browse/MESOS-2902 Repository: mesos Description (updated) ------- Jira: MESOS-2902 It is sometimes useful to enable an external script to configure the IP address the Mesos Master will bind to on the server, where it's not desirable to set the --ip flag and/or a "wrapper" script is not a viable option. This patch adds a --ip_discovery_script to point to a local script that will emit as its only output the IP address that the Master will bind to: only spaces and newlines are allowed; further, as we cannot use the `libprocess` sub-processing facilities, we cannot timeout the script, should this block for long times (or even forever). This will conflict with the --ip flag, so if both set, we will fail with an appropriate error message. Diffs ----- docs/configuration.md babbd2f67b32d4f317cfdf8bb87f8725917b0aca src/master/main.cpp fd4de4d0d9c3e9617408022d10b5e161bdc911e1 Diff: https://reviews.apache.org/r/36425/diff/ Testing (updated) ------- make check also tested against a couple of simple scripts that emulate the three possible cases: a valid IP; a bogus one; an error exit code. Thanks, Marco Massenzio --===============6522913486938993069==--