Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============8599723731656427213=="
MIME-Version: 1.0
Subject: Re: Review Request 36424: Created a command executor helper method.
From: "Alexander Rojas" <alexander@mesosphere.io>
To: "Benjamin Hindman" <benh@berkeley.edu>,
 "Ben Mahler" <benjamin.mahler@gmail.com>,
 "Paul Brett" <paul_b@twopensource.com>, "Cody Maloney" <cody@mesosphere.io>
Cc: "Marco Massenzio" <marco@mesosphere.io>,
 "mesos" <reviews@mesos.apache.org>,
 "Alexander Rojas" <alexander@mesosphere.io>
Date: Mon, 20 Jul 2015 08:03:22 -0000
Message-ID: <20150720080322.10542.47792@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Alexander Rojas" <noreply@reviews.apache.org>
References: <20150718020053.17363.58101@reviews.apache.org>
In-Reply-To: <20150718020053.17363.58101@reviews.apache.org>
Reply-To: "Alexander Rojas" <alexander@mesosphere.io>

--===============8599723731656427213==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36424/#review92232
-----------------------------------------------------------


3rdparty/libprocess/include/process/subprocess.hpp (line 364)
<https://reviews.apache.org/r/36424/#comment146283>

    Isn't `++cmdArgs.begin()` the same `cmdArgs.end()` ? I feel that pre-increment looks quite weird.
    
    If you still prefer the given style, I think `cmdArgs.begin() + 1` is still more readable and doesn't add complexity.


- Alexander Rojas


On July 18, 2015, 4 a.m., Marco Massenzio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36424/
> -----------------------------------------------------------
> 
> (Updated July 18, 2015, 4 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Cody Maloney, and Paul Brett.
> 
> 
> Bugs: MESOS-3035
>     https://issues.apache.org/jira/browse/MESOS-3035
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Jira: MESOS-2902
> 
> While researching how to execute an arbitrary script
> to detect the Master IP address, it emerged clearly that
> a helper method to execute an arbitrary command/script on
> a node and obtain either stdout or stderr would have been
> useful and avoided a lot of code repetition.
> 
> This could not be ultimately used for the purpose at hand,
> but I believe it to be useful enough (particularly, to avoid
> people doing "coding by copy&paste" and/or waste time
> researching the same functionality).
> 
> This would also be beneficial in MESOS-2830 and MESOS-2834
> factoring out the remote command execution logic.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 310cb4f8e4e2faa5545dffd196d7490c868bc5d6 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp f6acb204582a9e696c3b09d4e4c543bb052e97d4 
> 
> Diff: https://reviews.apache.org/r/36424/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>


--===============8599723731656427213==--