Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 81AA718BB9 for ; Sat, 18 Jul 2015 14:29:51 +0000 (UTC) Received: (qmail 12018 invoked by uid 500); 18 Jul 2015 14:29:51 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 11994 invoked by uid 500); 18 Jul 2015 14:29:51 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 11981 invoked by uid 99); 18 Jul 2015 14:29:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 18 Jul 2015 14:29:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8C0C71DDAE3; Sat, 18 Jul 2015 14:29:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6218368005408588338==" MIME-Version: 1.0 Subject: Re: Review Request 35797: Updated Frameworkinfo.capabilities on framework re-registration to support adding capabilities From: "Aditi Dixit" To: "Vinod Kone" Cc: "Aditi Dixit" , "mesos" Date: Sat, 18 Jul 2015 14:29:49 -0000 Message-ID: <20150718142949.17363.32329@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Aditi Dixit" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/35797/ X-Sender: "Aditi Dixit" References: <20150716201314.17363.90480@reviews.apache.org> In-Reply-To: <20150716201314.17363.90480@reviews.apache.org> Reply-To: "Aditi Dixit" X-ReviewRequest-Repository: mesos --===============6218368005408588338== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On July 16, 2015, 8:13 p.m., Vinod Kone wrote: > > src/tests/fault_tolerance_tests.cpp, line 1831 > > > > > > Nice test! Thanks :) > On July 16, 2015, 8:13 p.m., Vinod Kone wrote: > > src/master/master.hpp, line 534 > > > > > > s/capabilities_size()/capabilities.size()/ In mesos.pb.h, capabilities_size() is defined in line 1147 :) - Aditi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35797/#review91955 ----------------------------------------------------------- On July 18, 2015, 2:23 p.m., Aditi Dixit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35797/ > ----------------------------------------------------------- > > (Updated July 18, 2015, 2:23 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2880 > https://issues.apache.org/jira/browse/MESOS-2880 > > > Repository: mesos > > > Description > ------- > > This only updates the master, not the allocator. Added test too. > > > Diffs > ----- > > src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec > src/tests/fault_tolerance_tests.cpp 1070ccf17f98f6b3800684a5edd6517d90631c3e > > Diff: https://reviews.apache.org/r/35797/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Aditi Dixit > > --===============6218368005408588338==--