Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============1421645771357543064=="
MIME-Version: 1.0
Subject: Re: Review Request 36425: Enabling IP Discovery script
From: "Marco Massenzio" <marco@mesosphere.io>
To: "Benjamin Hindman" <benh@berkeley.edu>,
 "Cody Maloney" <cody@mesosphere.io>
Cc: "Marco Massenzio" <marco@mesosphere.io>,
 "mesos" <reviews@mesos.apache.org>
Date: Mon, 13 Jul 2015 21:34:23 -0000
Message-ID: <20150713213423.17362.4848@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Marco Massenzio" <noreply@reviews.apache.org>
References: <20150713211202.17362.94205@reviews.apache.org>
In-Reply-To: <20150713211202.17362.94205@reviews.apache.org>
Reply-To: "Marco Massenzio" <marco@mesosphere.io>

--===============1421645771357543064==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On July 13, 2015, 9:12 p.m., Cody Maloney wrote:
> > Generally looks reasonable to me. I haven't integration tested yet inside DCOS, will work on that before too long.

> reasonable

not exactly a ringing endorsement :) but I guess I'll take it...
care to give me a Ship it?


> On July 13, 2015, 9:12 p.m., Cody Maloney wrote:
> > docs/configuration.md, line 101
> > <https://reviews.apache.org/r/36425/diff/3/?file=1009992#file1009992line101>
> >
> >     nit: I don't like string here

You're right.
Changed to (both in the .md doc and the flag help string):
```
      "Optional IP discovery binary: if set, it is expected to emit\n"
      "the IP address which Master will try to bind to.\n"
      "Overrides the setting in --ip."
```


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36425/#review91518
-----------------------------------------------------------


On July 13, 2015, 7:25 p.m., Marco Massenzio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36425/
> -----------------------------------------------------------
> 
> (Updated July 13, 2015, 7:25 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Cody Maloney.
> 
> 
> Bugs: MESOS-2902
>     https://issues.apache.org/jira/browse/MESOS-2902
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Jira: MESOS-2902
> 
> It is sometimes useful to enable an external script to
> configure the IP address the Mesos Master will bind to
> on the server, where it's not desirable to set the
> --ip flag and/or a "wrapper" script is not a viable option.
> 
> This patch adds a --ip_discovery_script to point to a local
> script that will emit as its only output the IP address that
> the Master will bind to: only spaces and newlines are allowed;
> further, as we cannot use the `libprocess` sub-processing
> facilities, we cannot timeout the script, should this block
> for long times (or even forever).
> 
> This will override the --ip flag, which, even if set, will be
> ignored.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md feee5594c88112f77ce382cb3dd8628653f92d01 
>   src/master/main.cpp fd4de4d0d9c3e9617408022d10b5e161bdc911e1 
> 
> Diff: https://reviews.apache.org/r/36425/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>


--===============1421645771357543064==--