Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0C4C218950 for ; Mon, 13 Jul 2015 07:20:08 +0000 (UTC) Received: (qmail 69536 invoked by uid 500); 13 Jul 2015 07:20:08 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 69514 invoked by uid 500); 13 Jul 2015 07:20:08 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 69499 invoked by uid 99); 13 Jul 2015 07:20:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Jul 2015 07:20:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E7DA31D4666; Mon, 13 Jul 2015 07:20:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0924662612564827369==" MIME-Version: 1.0 Subject: Re: Review Request 35687: Added capabilities to state.json From: "Alexander Rukletsov" To: "Vinod Kone" , "Marco Massenzio" Cc: "Alexander Rukletsov" , "mesos" , "Aditi Dixit" Date: Mon, 13 Jul 2015 07:20:06 -0000 Message-ID: <20150713072006.17362.8231@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alexander Rukletsov" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/35687/ X-Sender: "Alexander Rukletsov" References: <20150620105019.1458.52065@reviews.apache.org> In-Reply-To: <20150620105019.1458.52065@reviews.apache.org> Reply-To: "Alexander Rukletsov" X-ReviewRequest-Repository: mesos --===============0924662612564827369== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On June 20, 2015, 10:50 a.m., Alexander Rukletsov wrote: > > src/master/http.cpp, line 124 > > > > > > Let's make it `foreachvalue` for consistency. > > Aditi Dixit wrote: > Hi, > I'm sorry, but I'm unable to understand how foreachvalue works. No worries, I was referring to `foreach` anyway : ). - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35687/#review88640 ----------------------------------------------------------- On July 12, 2015, 6:25 p.m., Aditi Dixit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35687/ > ----------------------------------------------------------- > > (Updated July 12, 2015, 6:25 p.m.) > > > Review request for mesos, Marco Massenzio and Vinod Kone. > > > Bugs: MESOS-2900 > https://issues.apache.org/jira/browse/MESOS-2900 > > > Repository: mesos > > > Description > ------- > > Added capabilities to state.json and test for the same > > > Diffs > ----- > > src/master/http.cpp 350383362311cfbc830965e1155a8515f0dfb332 > src/tests/master_tests.cpp 962455cc368c6e5405599d6565660d4c3fd0fc22 > > Diff: https://reviews.apache.org/r/35687/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Aditi Dixit > > --===============0924662612564827369==--