Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B11E218DAA for ; Sat, 11 Jul 2015 09:00:59 +0000 (UTC) Received: (qmail 15802 invoked by uid 500); 11 Jul 2015 09:00:59 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 15774 invoked by uid 500); 11 Jul 2015 09:00:59 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 15756 invoked by uid 99); 11 Jul 2015 09:00:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Jul 2015 09:00:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C78FCBBA3B; Sat, 11 Jul 2015 09:00:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8508581003425597265==" MIME-Version: 1.0 Subject: Re: Review Request 36181: Port CFS support to Docker Containerizer From: "haosdent huang" To: "Timothy Chen" Cc: "haosdent huang" , "mesos" Date: Sat, 11 Jul 2015 09:00:58 -0000 Message-ID: <20150711090058.1572.4599@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "haosdent huang" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36181/ X-Sender: "haosdent huang" References: <20150704173447.13308.79330@reviews.apache.org> In-Reply-To: <20150704173447.13308.79330@reviews.apache.org> Reply-To: "haosdent huang" X-ReviewRequest-Repository: mesos --===============8508581003425597265== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On July 4, 2015, 5:34 p.m., Timothy Chen wrote: > > src/slave/containerizer/docker.cpp, line 282 > > > > > > These flags are supported only after a certain docker version right? > > > > I think we need to log and disable this when the user is using a older version that doens't support these flags. > > haosdent huang wrote: > Is it possible to support cfs in older docker? Maybe we could change to that way. @tnachen, I return error when start the slave, or just need warning and disable it when start slave? - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36181/#review90392 ----------------------------------------------------------- On July 11, 2015, 8:59 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36181/ > ----------------------------------------------------------- > > (Updated July 11, 2015, 8:59 a.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-2154 > https://issues.apache.org/jira/browse/MESOS-2154 > > > Repository: mesos > > > Description > ------- > > Port CFS support to Docker Containerizer > > > Diffs > ----- > > src/slave/containerizer/docker.cpp cfb60177fe48ec0eeab12ff392c6c9f89634b92f > > Diff: https://reviews.apache.org/r/36181/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > > --===============8508581003425597265==--