Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0F5B0188C3 for ; Thu, 9 Jul 2015 18:47:28 +0000 (UTC) Received: (qmail 64400 invoked by uid 500); 9 Jul 2015 18:47:28 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 64376 invoked by uid 500); 9 Jul 2015 18:47:28 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 64357 invoked by uid 99); 9 Jul 2015 18:47:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Jul 2015 18:47:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3D924BB013; Thu, 9 Jul 2015 18:47:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5173204152730299293==" MIME-Version: 1.0 Subject: Re: Review Request 34138: AppC hash computation. From: "Vinod Kone" To: "Vinod Kone" , "Timothy Chen" , "Paul Brett" , "Chi Zhang" Cc: "mesos" , "Ian Downes" Date: Thu, 09 Jul 2015 18:47:27 -0000 Message-ID: <20150709184727.1573.53381@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/34138/ X-Sender: "Vinod Kone" References: <20150707194238.1572.50435@reviews.apache.org> In-Reply-To: <20150707194238.1572.50435@reviews.apache.org> Reply-To: "Vinod Kone" X-ReviewRequest-Repository: mesos --===============5173204152730299293== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34138/#review91145 ----------------------------------------------------------- src/slave/containerizer/provisioners/appc/hash.hpp (line 40) A class with only static methods seems weird. Why not put this in a namespace instead? Also, why is this defined here and not in libprocess? src/slave/containerizer/provisioners/appc/hash.hpp (line 61) This should take a 'Path' type instead of 'string'. src/slave/containerizer/provisioners/appc/hash.hpp (line 69) looks like 'command()' is only used once here. why split it into a function? - Vinod Kone On July 7, 2015, 7:42 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34138/ > ----------------------------------------------------------- > > (Updated July 7, 2015, 7:42 p.m.) > > > Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > AppC hash computation. > > > Diffs > ----- > > src/Makefile.am e7de0f3d1a5efeaef47d5074defe3b40db94f573 > src/slave/containerizer/provisioners/appc/hash.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/34138/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > > --===============5173204152730299293==--