Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3FB8418070 for ; Wed, 1 Jul 2015 22:20:23 +0000 (UTC) Received: (qmail 63965 invoked by uid 500); 1 Jul 2015 22:20:23 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 63957 invoked by uid 500); 1 Jul 2015 22:20:23 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 63938 invoked by uid 99); 1 Jul 2015 22:20:22 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jul 2015 22:20:22 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1B822B1E85; Wed, 1 Jul 2015 22:20:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7739286442875800618==" MIME-Version: 1.0 Subject: Re: Review Request 36079: Added Subscribe call support to the master and the C++ scheduler library. From: "Vinod Kone" To: "Benjamin Hindman" , "Ben Mahler" , "Marco Massenzio" Cc: "Isabel Jimenez" , "Vinod Kone" , "mesos" , "Anand Mazumdar" , "Mesos ReviewBot" Date: Wed, 01 Jul 2015 22:20:22 -0000 Message-ID: <20150701222022.13307.58927@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36079/ X-Sender: "Vinod Kone" References: <20150701052805.13308.84701@reviews.apache.org> In-Reply-To: <20150701052805.13308.84701@reviews.apache.org> Reply-To: "Vinod Kone" X-ReviewRequest-Repository: mesos --===============7739286442875800618== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36079/ ----------------------------------------------------------- (Updated July 1, 2015, 10:20 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, and Marco Massenzio. Changes ------- anand's comment. NNFR. Bugs: MESOs-2551 https://issues.apache.org/jira/browse/MESOs-2551 Repository: mesos Description ------- Haven't refactored registeredFramework() and re-registeredFramework() yet, but made Master::subscribe() call them instead. Diffs (updated) ----- src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 src/master/master.cpp 34ce744f84465ecc9aeecd5fdc3d06047a4b7d92 src/scheduler/scheduler.cpp f360e4d062488986b14e3d48d140996e8ed9e7d6 Diff: https://reviews.apache.org/r/36079/diff/ Testing ------- make check Thanks, Vinod Kone --===============7739286442875800618==--