mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Review Request 36919: Pulled out call validation.
Date Wed, 29 Jul 2015 19:30:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36919/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar and Vinod Kone.


Repository: mesos


Description
-------

Call validation was duplicated across scheduler.cpp and the master.

With the http api, we will also want an easy way to validate and drop calls that are coming
in to the master.


Diffs
-----

  src/master/master.hpp 2331173fb9aeca77227fb09b899cb123eb205b4b 
  src/master/master.cpp c584cb9f5aeb6806657059a3204ce1c680d4214a 
  src/master/validation.hpp 469d6f56c3de28a34177124aae81ce24cb4ad160 
  src/master/validation.cpp 9d128aa1b349b018b8e4a1916434d848761ca051 
  src/scheduler/scheduler.cpp 6887ed109a4b7342a460fff2ebbe1d98ff3e9092 

Diff: https://reviews.apache.org/r/36919/diff/


Testing
-------

make check

This also makes it easier to unit test this validation going forward.


Thanks,

Ben Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message