mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 36830: Libprocess: Introduced configurable `UNIMPLEMENTED` macro.
Date Mon, 27 Jul 2015 17:56:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36830/#review93145
-----------------------------------------------------------

Ship it!


Ship It!

- Joseph Wu


On July 27, 2015, 12:17 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36830/
> -----------------------------------------------------------
> 
> (Updated July 27, 2015, 12:17 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and Michael
Park.
> 
> 
> Bugs: MESOS-3122
>     https://issues.apache.org/jira/browse/MESOS-3122
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> use --enable-static-unimplemented to get compile time errors as opposed
> to runtime errors.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/configure.ac 7d1221bd5ddfc4fa816b0bbea0be5c6b20000cbb 
> 
> Diff: https://reviews.apache.org/r/36830/diff/
> 
> 
> Testing
> -------
> 
> created a function with an `UNIMPLEMENTED()` body and verified the runtime error occured
when configured by default, and a compile-time error ocurred when configured with `--enable-static-unimplemented`
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message