mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 36760: Handle scheduler pid as optional in the slave.
Date Fri, 24 Jul 2015 22:27:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36760/
-----------------------------------------------------------

(Updated July 24, 2015, 10:27 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
-------

Cleanups from reviews.


Bugs: MESOS-3132
    https://issues.apache.org/jira/browse/MESOS-3132


Repository: mesos


Description
-------

This is anticipation of HTTP scheduler support in 0.24.0.
Note that the 'pid' is set for driver-based schedulers. The
corresponding master changes to not set 'pid' for HTTP
schedulers have not occurred yet.


Diffs (updated)
-----

  src/master/master.cpp 7796630a93705bd62157e98e1e4855c68ea7cd0a 
  src/messages/messages.proto 165a16d91616b75c839c7fbf188dc49f029a8c45 
  src/slave/slave.hpp dec4ca8323e151a6d0f9139214ff0ef6e3e3375a 
  src/slave/slave.cpp dc12c45516ab39d74a5c29b657f22f74d0acf24e 
  src/slave/state.hpp 4e00468a777145e3c61b8dee7dfe496f8d65b0e4 
  src/tests/mesos.hpp 69134e1c2664ca24a1ecd80a662c841311104a6a 
  src/tests/mesos.cpp f09ef0f99573716de8905f49dcc0c9df20e31ea9 
  src/tests/slave_tests.cpp b145d76cf9e96fe89a5e3df1c4611a6b146585e9 

Diff: https://reviews.apache.org/r/36760/diff/


Testing
-------

Added tests in [r/36761](https://reviews.apache.org/r/36761/).


Thanks,

Ben Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message