mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aditi Dixit" <aditi9di...@gmail.com>
Subject Re: Review Request 35797: Updated Frameworkinfo.capabilities on framework re-registration to support adding capabilities
Date Sat, 18 Jul 2015 14:29:49 GMT


> On July 16, 2015, 8:13 p.m., Vinod Kone wrote:
> > src/tests/fault_tolerance_tests.cpp, line 1831
> > <https://reviews.apache.org/r/35797/diff/3/?file=1013501#file1013501line1831>
> >
> >     Nice test!

Thanks :)


> On July 16, 2015, 8:13 p.m., Vinod Kone wrote:
> > src/master/master.hpp, line 534
> > <https://reviews.apache.org/r/35797/diff/3/?file=1013500#file1013500line534>
> >
> >     s/capabilities_size()/capabilities.size()/

In mesos.pb.h, capabilities_size() is defined in line 1147 :)


- Aditi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35797/#review91955
-----------------------------------------------------------


On July 18, 2015, 2:23 p.m., Aditi Dixit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35797/
> -----------------------------------------------------------
> 
> (Updated July 18, 2015, 2:23 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2880
>     https://issues.apache.org/jira/browse/MESOS-2880
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This only updates the master, not the allocator. Added test too.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec 
>   src/tests/fault_tolerance_tests.cpp 1070ccf17f98f6b3800684a5edd6517d90631c3e 
> 
> Diff: https://reviews.apache.org/r/35797/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message