mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 36518: Fixed a bug in master to properly handle resubscription.
Date Wed, 15 Jul 2015 20:28:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36518/#review91813
-----------------------------------------------------------


Patch looks great!

Reviews applied: [36518]

All tests passed.

- Mesos ReviewBot


On July 15, 2015, 6:40 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36518/
> -----------------------------------------------------------
> 
> (Updated July 15, 2015, 6:40 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3055
>     https://issues.apache.org/jira/browse/MESOS-3055
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In the process of fixing this, added an additional check in Master::registerFramework()
that should've been there in the first place. Similar check exists in Master::reregisterFramework().
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp b877676afa6f3833eb7d2fb06beeaa288bd8bd5d 
>   src/tests/scheduler_tests.cpp 946fa8245d8ab35e04bad642d69114caf0ccf6a9 
> 
> Diff: https://reviews.apache.org/r/36518/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message