mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 35687: Added capabilities to state.json
Date Mon, 13 Jul 2015 07:17:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35687/#review91436
-----------------------------------------------------------



src/master/http.cpp (line 124)
<https://reviews.apache.org/r/35687/#comment144809>

    Please add a space between `foreach` and a bracket for consistency: `foreach (...`



src/tests/master_tests.cpp (line 2949)
<https://reviews.apache.org/r/35687/#comment144811>

    We tend to limit comments to 70 chars, this line looks longer. Mind wrapping it?



src/tests/master_tests.cpp (line 2997)
<https://reviews.apache.org/r/35687/#comment144817>

    We use `lowerCamelCase` for variable names, please rename.



src/tests/master_tests.cpp (line 3001)
<https://reviews.apache.org/r/35687/#comment144814>

    Instead of the hardcoded constant, it makes sense to use `FrameworkInfo::Capability::Type_Name()`
IMO.


- Alexander Rukletsov


On July 12, 2015, 6:25 p.m., Aditi Dixit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35687/
> -----------------------------------------------------------
> 
> (Updated July 12, 2015, 6:25 p.m.)
> 
> 
> Review request for mesos, Marco Massenzio and Vinod Kone.
> 
> 
> Bugs: MESOS-2900
>     https://issues.apache.org/jira/browse/MESOS-2900
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added capabilities to state.json and test for the same
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 350383362311cfbc830965e1155a8515f0dfb332 
>   src/tests/master_tests.cpp 962455cc368c6e5405599d6565660d4c3fd0fc22 
> 
> Diff: https://reviews.apache.org/r/35687/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message