mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kapil Arya" <ka...@mesosphere.io>
Subject Re: Review Request 36428: Remove erroneous code for isolator modules.
Date Sun, 12 Jul 2015 05:16:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36428/#review91402
-----------------------------------------------------------


It looks like it was introduced in f511395e instead (unless I am missing something here):

https://github.com/apache/mesos/commit/f511395e#diff-c8ca6e064a8bf7b1b3c70e6525eabeceR129

- Kapil Arya


On July 12, 2015, 12:44 a.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36428/
> -----------------------------------------------------------
> 
> (Updated July 12, 2015, 12:44 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Kapil Arya, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Kapil: this appears to have been introduced in your commit 3a179ce2. Can you please verify
this should be removed.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 47d146125dfd4ea909e7ec9d94f41cfa11d035e5

> 
> Diff: https://reviews.apache.org/r/36428/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Downes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message