mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Downes" <ian.dow...@gmail.com>
Subject Re: Review Request 34135: Add filesystem/ isolators for persistent volumes.
Date Sat, 11 Jul 2015 00:05:31 GMT


> On June 25, 2015, 12:47 p.m., Jie Yu wrote:
> > src/slave/containerizer/isolators/filesystem/linux.cpp, lines 406-407
> > <https://reviews.apache.org/r/34135/diff/2/?file=989747#file989747line406>
> >
> >     Do you need to umount persistent volumes as well?

As the comment states, it "notably this includes persistent volume mounts" :-)


> On June 25, 2015, 12:47 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, lines 158-166
> > <https://reviews.apache.org/r/34135/diff/2/?file=989751#file989751line158>
> >
> >     Hum... why this logic is under 'if (ModuleManager::contains<Isolator>(type)'
?

Good catch! No idea why it was there in the first place and why I perpetuated the erroneous
code.


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34135/#review84775
-----------------------------------------------------------


On June 22, 2015, 9:41 a.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34135/
> -----------------------------------------------------------
> 
> (Updated June 22, 2015, 9:41 a.m.)
> 
> 
> Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved code from Mesos Containerizer to filesystem isolators
>  - filesystem/posix (symlinks, doesn't support container rootfs)
>  - filesystem/linux (bind mounts, does support container rootfs)
> 
> The filesystem/posix isolator will be automatically included if no filesystem/ isolator
is specified.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am e7de0f3d1a5efeaef47d5074defe3b40db94f573 
>   src/slave/containerizer/isolators/filesystem/linux.hpp PRE-CREATION 
>   src/slave/containerizer/isolators/filesystem/linux.cpp PRE-CREATION 
>   src/slave/containerizer/isolators/filesystem/posix.hpp PRE-CREATION 
>   src/slave/containerizer/isolators/filesystem/posix.cpp PRE-CREATION 
>   src/slave/containerizer/linux_launcher.cpp 8eae258d81229e19f8c587f5e023b1df7deed025

>   src/slave/containerizer/mesos/containerizer.cpp 8c102fb7d1f79ee768cb06de3a976ea12f958712

> 
> Diff: https://reviews.apache.org/r/34135/diff/
> 
> 
> Testing
> -------
> 
> existing persistent volumes tests.
> 
> 
> Thanks,
> 
> Ian Downes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message