mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Review Request 36282: Remove os environment for docker executor enviornment setup.
Date Tue, 07 Jul 2015 22:06:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36282/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Joerg Schad.


Bugs: MESOS-2996
    https://issues.apache.org/jira/browse/MESOS-2996


Repository: mesos


Description
-------

Remove os environment when calling executorEnvironment when running docker executors, since
all the environment variables will be 
passed into the container and causes bad behavior such as overriding hostname.


Diffs
-----

  src/slave/containerizer/docker.hpp 646a277be21deaded47324bea5474bd68699f25f 
  src/slave/containerizer/docker.cpp 6eb1c84b1a6ef17c3e2ea2028e2f2d75110176ba 

Diff: https://reviews.apache.org/r/36282/diff/


Testing
-------

make check


Thanks,

Timothy Chen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message