mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Review Request 36255: Rearranged Option<> constructors to suppress compiler bug.
Date Tue, 07 Jul 2015 12:34:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36255/
-----------------------------------------------------------

Review request for mesos, Adam B and Michael Park.


Bugs: MESOS-2991
    https://issues.apache.org/jira/browse/MESOS-2991


Repository: mesos


Description
-------

We believe there is a compiler bug in the `g++` compiler based on LLVM 3.5 on Mac OS 10.10.4.
The bug seems to be related to the template instantiation mechanism. Rearranging c-tors of
the affected class suppresses the bug for the given compiler version.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 3d9b7a7568de6734097733f4e6d59acba629b849


Diff: https://reviews.apache.org/r/36255/diff/


Testing
-------

Make check on Mac OS 10.10.4 with the following compiler:
```
g++ --version
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 6.0 (clang-600.0.54) (based on LLVM 3.5svn)
Target: x86_64-apple-darwin14.4.0
Thread model: posix
```


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message