mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <alexan...@mesosphere.io>
Subject Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
Date Fri, 03 Jul 2015 07:49:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36048/
-----------------------------------------------------------

(Updated July 3, 2015, 9:49 a.m.)


Review request for mesos and Till Toenshoff.


Changes
-------

Updated summary.


Summary (updated)
-----------------

Updated authorizer to allow for modularized implementations.


Bugs: MESOS-2945
    https://issues.apache.org/jira/browse/MESOS-2945


Repository: mesos


Description
-------

Breaks the declaration of the `Authorizer` interface and its default implementation `LocalAuthorizer`
in different files.

Makes the `Authorizer` interface declaration public.

Following the patter in the `Authenticator` it generates a default constructor which is required
when writing a `TypeTest` in a follow up patch, and an `initialize` method.

Other changes are just updates to allow for compilation.


Diffs
-----

  include/mesos/authorizer/authorizer.hpp PRE-CREATION 
  include/mesos/authorizer/authorizer.proto PRE-CREATION 
  include/mesos/mesos.proto 3dd4a5b7a4b3bc56bdc690d6adf05f88c0d28273 
  include/mesos/type_utils.hpp e7bfe8ca60af945e76b5d85ab37cc97b17ff1b4a 
  src/Makefile.am addb63f615f16ae6b25f745b2e79fd9fc0e27851 
  src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f 
  src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc 
  src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 
  src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 
  src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff 
  src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f 
  src/master/http.cpp 2be613b2e4c913b74c12d0d8f2d0e25da3cd3656 
  src/master/main.cpp 2624b7ea4920a534c98f5dfbf9286c54c50f11a9 
  src/master/master.hpp fb4d6fac85e284987ec8fbf6949b5023875573fb 
  src/master/master.cpp c5a4875f0d43c5091ae9a52c6b1d04105dfa3914 
  src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 
  src/tests/cluster.hpp cfe7ef0c7a6dc62cddc3e5f5b5b28c8bcb2bed26 
  src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3 
  src/tests/mesos.cpp 5eab6dea6058865847425ab8d31708c92c6f098a 

Diff: https://reviews.apache.org/r/36048/diff/


Testing
-------

make check


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message