Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EA7DB18864 for ; Tue, 30 Jun 2015 02:00:51 +0000 (UTC) Received: (qmail 14482 invoked by uid 500); 30 Jun 2015 02:00:51 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 14459 invoked by uid 500); 30 Jun 2015 02:00:51 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 14445 invoked by uid 99); 30 Jun 2015 02:00:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Jun 2015 02:00:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 064D1AC55C; Tue, 30 Jun 2015 02:00:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1570987937140583805==" MIME-Version: 1.0 Subject: Re: Review Request 35711: Disallow special characters in role name. From: "haosdent huang" To: "Adam B" , "Jie Yu" Cc: "haosdent huang" , "mesos" Date: Tue, 30 Jun 2015 02:00:50 -0000 Message-ID: <20150630020050.13308.59832@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "haosdent huang" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/35711/ X-Sender: "haosdent huang" References: <20150629111726.13308.79079@reviews.apache.org> In-Reply-To: <20150629111726.13308.79079@reviews.apache.org> Reply-To: "haosdent huang" X-ReviewRequest-Repository: mesos --===============1570987937140583805== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On June 29, 2015, 11:17 a.m., Adam B wrote: > > src/common/validation.hpp, lines 27-34 > > > > > > I'm not convinced this is the right namespace/scope for a freestanding validate() function. Maybe, like we have a Resource protobuf message and a Resources class with parse() and validate(), we should also have a Roles::validate(). > > Jie Yu wrote: > +1 > > Initially, the patch only contains validation at the master's side, and that's the reason I sugguested to put that into master/validation.hpp|cpp. I agree with Adam that putting that in Roles. Sorry about that! Thank you for your review. Let me update it. @jieyu @adam-mesos - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review89630 ----------------------------------------------------------- On June 27, 2015, 11:35 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35711/ > ----------------------------------------------------------- > > (Updated June 27, 2015, 11:35 a.m.) > > > Review request for mesos, Adam B and Jie Yu. > > > Bugs: MESOS-2210 > https://issues.apache.org/jira/browse/MESOS-2210 > > > Repository: mesos > > > Description > ------- > > Disallow special characters in role name. > > > Diffs > ----- > > src/Makefile.am a064d17a6b62e6e3c8e190135bcc8cbbb0051ed5 > src/common/resources.cpp eb5476a0365fe65f474afd0ab7a52ad7f1e04521 > src/common/validation.hpp PRE-CREATION > src/common/validation.cpp PRE-CREATION > src/master/flags.cpp 4377715029878cfee36f067e9c53c42b522b79d8 > src/slave/flags.cpp 6ba5a1bdc9f91aa1977f13b3aeec0fe0604687a0 > src/tests/common/validation_tests.cpp PRE-CREATION > src/tests/resources_tests.cpp 30c10f3246b807800985f20f8835090657a2d56e > > Diff: https://reviews.apache.org/r/35711/diff/ > > > Testing > ------- > > make -j8 check > > > Thanks, > > haosdent huang > > --===============1570987937140583805==--