Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F29AA1842D for ; Thu, 18 Jun 2015 23:11:16 +0000 (UTC) Received: (qmail 70781 invoked by uid 500); 18 Jun 2015 23:11:16 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 70756 invoked by uid 500); 18 Jun 2015 23:11:16 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 70742 invoked by uid 99); 18 Jun 2015 23:11:16 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Jun 2015 23:11:16 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 39E961DFE6A; Thu, 18 Jun 2015 23:11:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2887568381107233821==" MIME-Version: 1.0 Subject: Re: Review Request 35335: Fixed JSON output error TaskInfo executor_id in slave/http.cpp From: "Brendan Chang" To: "Joris Van Remoortere" , "Benjamin Hindman" Cc: "Brendan Chang" , "mesos" Date: Thu, 18 Jun 2015 23:11:16 -0000 Message-ID: <20150618231116.1512.55712@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Brendan Chang" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/35335/ X-Sender: "Brendan Chang" References: <20150617222835.1515.49750@reviews.apache.org> In-Reply-To: <20150617222835.1515.49750@reviews.apache.org> Reply-To: "Brendan Chang" X-ReviewRequest-Repository: mesos --===============2887568381107233821== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35335/ ----------------------------------------------------------- (Updated June 18, 2015, 11:11 p.m.) Review request for mesos, Benjamin Hindman and Joris Van Remoortere. Changes ------- Minor syntactical changes Bugs: MESOS-2598 https://issues.apache.org/jira/browse/MESOS-2598 Repository: mesos Description ------- Fixed JSON output error TaskInfo executor_id in slave/http.cpp Diffs (updated) ----- src/slave/http.cpp bc25bdd33277dbfa30410ad081ea09f0fc39c598 src/tests/slave_tests.cpp 8709874411835c99b8900102fd014a9e28f2b208 Diff: https://reviews.apache.org/r/35335/diff/ Testing (updated) ------- Extended SlaveEndpoint test to launch a task and check for correct executor_id in state.json. It was difficult to mock queued_tasks for testing (see https://issues.apache.org/jira/browse/MESOS-2896), so the extension to SlaveEndpoint verifies the executor_id format for general tasks. Thanks, Brendan Chang --===============2887568381107233821==--