Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============6735737441928486124=="
MIME-Version: 1.0
Subject: Re: Review Request 35433: Send StatusUpdates if checkpointed
 resources don't exist on the slave.
From: "Jie Yu" <yujie.jay@gmail.com>
To: "Benjamin Hindman" <benh@berkeley.edu>,
 "Alexander Rukletsov" <rukletsov@gmail.com>, "Jie Yu" <yujie.jay@gmail.com>
Cc: "mesos" <reviews@mesos.apache.org>, "Michael Park" <mcypark@gmail.com>
Date: Thu, 18 Jun 2015 17:27:21 -0000
Message-ID: <20150618172721.1515.52656@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Jie Yu" <noreply@reviews.apache.org>
References: <20150618170513.1512.92486@reviews.apache.org>
In-Reply-To: <20150618170513.1512.92486@reviews.apache.org>
Reply-To: "Jie Yu" <yujie.jay@gmail.com>

--===============6735737441928486124==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35433/#review88406
-----------------------------------------------------------


src/slave/slave.cpp (lines 1403 - 1421)
<https://reviews.apache.org/r/35433/#comment140916>

    Hum, are you sending multiple status update if there are multiple 'resource's in 'checkpointedTaskResources'?


src/slave/slave.cpp (line 1409)
<https://reviews.apache.org/r/35433/#comment140915>

    Have we decided to not capture temp variable by const ref? Maybe you want to do a sweep to fix that in this file?


src/slave/slave.cpp (lines 1428 - 1450)
<https://reviews.apache.org/r/35433/#comment140917>

    Ditto here.


- Jie Yu


On June 18, 2015, 5:05 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35433/
> -----------------------------------------------------------
> 
> (Updated June 18, 2015, 5:05 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> No bug was observed (yet), but realized I forgot about this in the dynamic reservations patches.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp a5ad29f59fadba919ed82ba2892c2febe551660b 
> 
> Diff: https://reviews.apache.org/r/35433/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


--===============6735737441928486124==--