Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3E8CA18FCB for ; Mon, 15 Jun 2015 22:26:37 +0000 (UTC) Received: (qmail 76268 invoked by uid 500); 15 Jun 2015 22:26:37 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 76244 invoked by uid 500); 15 Jun 2015 22:26:37 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 76229 invoked by uid 99); 15 Jun 2015 22:26:36 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Jun 2015 22:26:36 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 52AC11DFE50; Mon, 15 Jun 2015 22:26:36 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6097254413317227729==" MIME-Version: 1.0 Subject: Re: Review Request 30339: Call hookmanager only if some hooks are installed. From: "Kapil Arya" To: "Niklas Nielsen" , "Till Toenshoff" Cc: "Mesos ReviewBot" , "mesos" Date: Mon, 15 Jun 2015 22:26:36 -0000 Message-ID: <20150615222636.9295.50153@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Kapil Arya" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/30339/ X-Sender: "Kapil Arya" References: <20150615212237.32039.28328@reviews.apache.org> In-Reply-To: <20150615212237.32039.28328@reviews.apache.org> Reply-To: "Kapil Arya" X-ReviewRequest-Repository: mesos --===============6097254413317227729== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30339/ ----------------------------------------------------------- (Updated June 15, 2015, 6:26 p.m.) Review request for mesos, Niklas Nielsen and Till Toenshoff. Changes ------- Removed unneeded changes from hook tests. Repository: mesos Description ------- Call hook manager only if hooks were specified on the commandline. Diffs (updated) ----- src/hook/manager.hpp 638e19f5062f070cd0ec94d830615a2c73fd357d src/hook/manager.cpp b43b91878cc9f0f5f5d081b9b3af0768c07c282b src/master/master.cpp 0137c37a42d4f7a9057568a8cd7b662ed92be353 src/slave/containerizer/containerizer.cpp e995ce602261c18373ac09c823638c4a252cca86 src/slave/slave.cpp 67732a40ef683cb0188425f0bba8fe8ab83e461c Diff: https://reviews.apache.org/r/30339/diff/ Testing ------- make check Thanks, Kapil Arya --===============6097254413317227729==--