Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6524D18855 for ; Tue, 9 Jun 2015 17:45:40 +0000 (UTC) Received: (qmail 49376 invoked by uid 500); 9 Jun 2015 17:45:40 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 49350 invoked by uid 500); 9 Jun 2015 17:45:40 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 49324 invoked by uid 99); 9 Jun 2015 17:45:40 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Jun 2015 17:45:40 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 84C8E1DF932; Tue, 9 Jun 2015 17:45:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3785523574429383672==" MIME-Version: 1.0 Subject: Re: Review Request 11108: Simplified os::hostname() in libstout. From: "Niklas Nielsen" To: "Benjamin Hindman" Cc: "Niklas Nielsen" , "Brenden Matthews" , "mesos" Date: Tue, 09 Jun 2015 17:45:38 -0000 Message-ID: <20150609174538.27736.17352@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Niklas Nielsen" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/11108/ X-Sender: "Niklas Nielsen" References: <20131022190442.3694.62700@reviews.apache.org> In-Reply-To: <20131022190442.3694.62700@reviews.apache.org> Reply-To: "Niklas Nielsen" X-ReviewRequest-Repository: mesos-incubating --===============3785523574429383672== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11108/#review87241 ----------------------------------------------------------- @brenden: Still want this in? If not, let's close it for now. - Niklas Nielsen On Oct. 22, 2013, 12:04 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11108/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2013, 12:04 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-incubating > > > Description > ------- > > Simplified os::hostname() in libstout. > > Review: https://reviews.apache.org/r/11108 > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 1b3fb47d7567b5467fef2a2bb15d5c4a2ea42aa5 > > Diff: https://reviews.apache.org/r/11108/diff/ > > > Testing > ------- > > Used in production at airbnb. > > make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3 > > > Thanks, > > Brenden Matthews > > --===============3785523574429383672==--