Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 73F411824E for ; Tue, 9 Jun 2015 00:34:16 +0000 (UTC) Received: (qmail 88744 invoked by uid 500); 9 Jun 2015 00:34:16 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 88721 invoked by uid 500); 9 Jun 2015 00:34:16 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 88705 invoked by uid 99); 9 Jun 2015 00:34:16 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Jun 2015 00:34:16 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0B9331DF7EF; Tue, 9 Jun 2015 00:34:15 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3756115060620125469==" MIME-Version: 1.0 Subject: Re: Review Request 35164: Added callback to the QoS Controller to retrieve usages from the monitor. From: "Jie Yu" To: "Niklas Nielsen" , "Vinod Kone" , "Szymon Konefal" , "Jie Yu" Cc: "Bartek Plotka" , "mesos" Date: Tue, 09 Jun 2015 00:34:15 -0000 Message-ID: <20150609003415.27735.65476@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jie Yu" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/35164/ X-Sender: "Jie Yu" References: <20150605234445.7996.38449@reviews.apache.org> In-Reply-To: <20150605234445.7996.38449@reviews.apache.org> Reply-To: "Jie Yu" X-ReviewRequest-Repository: mesos --===============3756115060620125469== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35164/#review87106 ----------------------------------------------------------- I think the interface of getting resource usage is going to change per discussion here: https://issues.apache.org/jira/browse/MESOS-2818 - Jie Yu On June 5, 2015, 11:44 p.m., Bartek Plotka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35164/ > ----------------------------------------------------------- > > (Updated June 5, 2015, 11:44 p.m.) > > > Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod Kone. > > > Bugs: MESOS-2823 > https://issues.apache.org/jira/browse/MESOS-2823 > > > Repository: mesos > > > Description > ------- > > Passed callback to the QoS Controller to retrieve ResourceUsage from Resource Monitor on demand. > > This is neccessary, since QoS Controller needs data (current statistics for each executor) on which it will base its potential corrections. > > > Diffs > ----- > > include/mesos/slave/qos_controller.hpp 1d89acfd9c742b044674e0a0815f9f01eccb69b3 > src/slave/qos_controller.hpp b37798303561eb79aee202b9c110794517eeed06 > src/slave/qos_controller.cpp 81c4b3e658902be0438f42d9e86911e424828a73 > src/slave/slave.cpp 054929b156374a8929ac9fffb032045f13c3eb43 > src/tests/mesos.hpp 087953d6bc716f11c315a0736f06f712d7f69417 > > Diff: https://reviews.apache.org/r/35164/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Bartek Plotka > > --===============3756115060620125469==--