Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 045A018615 for ; Mon, 8 Jun 2015 13:46:05 +0000 (UTC) Received: (qmail 48122 invoked by uid 500); 8 Jun 2015 13:46:01 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 48101 invoked by uid 500); 8 Jun 2015 13:46:01 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 48079 invoked by uid 99); 8 Jun 2015 13:46:01 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Jun 2015 13:46:01 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 70DF81DF3AD; Mon, 8 Jun 2015 13:46:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4966533108376809944==" MIME-Version: 1.0 Subject: Re: Review Request 34703: Added stream manipulators for the Time object. From: "Till Toenshoff" To: "Michael Park" , "Nikita Vetoshkin" , "Bernd Mathiske" , "Till Toenshoff" Cc: "Alexander Rojas" , "mesos" Date: Mon, 08 Jun 2015 13:46:00 -0000 Message-ID: <20150608134600.27736.80424@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Till Toenshoff" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/34703/ X-Sender: "Till Toenshoff" References: <20150529125931.8660.67518@reviews.apache.org> In-Reply-To: <20150529125931.8660.67518@reviews.apache.org> Reply-To: "Till Toenshoff" X-ReviewRequest-Repository: mesos --===============4966533108376809944== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34703/#review87028 ----------------------------------------------------------- 3rdparty/libprocess/include/process/time.hpp Move the opening brace to the first line please (like you did below). 3rdparty/libprocess/include/process/time.hpp Lets make this a copy instead to prevent weird bugs introduced by taking references to temporals. 3rdparty/libprocess/include/process/time.hpp `const Time time;` - Till Toenshoff On May 29, 2015, 12:59 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34703/ > ----------------------------------------------------------- > > (Updated May 29, 2015, 12:59 p.m.) > > > Review request for mesos, Bernd Mathiske, Michael Park, Nikita Vetoshkin, and Till Toenshoff. > > > Bugs: mesos-708 > https://issues.apache.org/jira/browse/mesos-708 > > > Repository: mesos > > > Description > ------- > > Adds some manipulator classes which allows formatting Time objects to ostreams. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/time.hpp c5ab2a3cfa83590eb6612152ae365dd67f51cea9 > 3rdparty/libprocess/src/tests/time_tests.cpp be314182c65c05d439b81aa5248a71d93f6f0a0b > > Diff: https://reviews.apache.org/r/34703/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > > --===============4966533108376809944==--