Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DF0EA185A1 for ; Fri, 5 Jun 2015 22:24:27 +0000 (UTC) Received: (qmail 5994 invoked by uid 500); 5 Jun 2015 22:24:27 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 5971 invoked by uid 500); 5 Jun 2015 22:24:27 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 5957 invoked by uid 99); 5 Jun 2015 22:24:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jun 2015 22:24:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D9D221DF70B; Fri, 5 Jun 2015 22:24:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2504869552748435380==" MIME-Version: 1.0 Subject: Re: Review Request 35119: Introduced metrics for revocable resources. From: "Mesos ReviewBot" To: "Vinod Kone" Cc: "Jiang Yan Xu" , "Mesos ReviewBot" , "mesos" Date: Fri, 05 Jun 2015 22:24:26 -0000 Message-ID: <20150605222426.7996.66810@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Mesos ReviewBot" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/35119/ X-Sender: "Mesos ReviewBot" References: <20150605211313.7997.86113@reviews.apache.org> In-Reply-To: <20150605211313.7997.86113@reviews.apache.org> Reply-To: "Mesos ReviewBot" X-ReviewRequest-Repository: mesos --===============2504869552748435380== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35119/#review86853 ----------------------------------------------------------- Patch looks great! Reviews applied: [35118, 35119] All tests passed. - Mesos ReviewBot On June 5, 2015, 9:13 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35119/ > ----------------------------------------------------------- > > (Updated June 5, 2015, 9:13 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2776 > https://issues.apache.org/jira/browse/MESOS-2776 > > > Repository: mesos > > > Description > ------- > > state.json changes are in a subsequent review. > > > Diffs > ----- > > src/master/master.hpp deeb0d8c87a13315206556e1d0974cdd13e8224f > src/master/master.cpp be0db42da3c59761aa154439653d715556465256 > src/master/metrics.hpp 833033c1912daee429b45423d24d365d8699a428 > src/master/metrics.cpp 264252c5159990fdf7a4569933a305d07bd7dd6e > src/tests/oversubscription_tests.cpp afd7ff4f2b50cb20cc2c8865b655ad1f8eb0c8b7 > > Diff: https://reviews.apache.org/r/35119/diff/ > > > Testing > ------- > > make check. > > - Modified a test to test the `total` resources metrics. > - We don't have unit tests that use the revocable resources yet, when we add that we should check `used` resources metrics too. > > > Thanks, > > Jiang Yan Xu > > --===============2504869552748435380==--