Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 426B21860D for ; Wed, 3 Jun 2015 16:33:34 +0000 (UTC) Received: (qmail 71133 invoked by uid 500); 3 Jun 2015 16:33:34 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 71110 invoked by uid 500); 3 Jun 2015 16:33:34 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 71095 invoked by uid 99); 3 Jun 2015 16:33:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jun 2015 16:33:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8068B1DF2E9; Wed, 3 Jun 2015 16:33:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7546645883246067651==" MIME-Version: 1.0 Subject: Re: Review Request 35000: Doxygen'ized Subprocess. From: "Joerg Schad" To: "Joerg Schad" , "Bernd Mathiske" Cc: "Benjamin Hindman" , "mesos" Date: Wed, 03 Jun 2015 16:33:33 -0000 Message-ID: <20150603163333.7997.46852@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Joerg Schad" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/35000/ X-Sender: "Joerg Schad" References: <20150603134517.7997.6560@reviews.apache.org> In-Reply-To: <20150603134517.7997.6560@reviews.apache.org> Reply-To: "Joerg Schad" X-ReviewRequest-Repository: mesos --===============7546645883246067651== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35000/#review86404 ----------------------------------------------------------- 3rdparty/libprocess/include/process/subprocess.hpp s/returns/return 3rdparty/libprocess/include/process/subprocess.hpp s/returns/return 3rdparty/libprocess/include/process/subprocess.hpp s/returns/return same for rest of file Great effort, makes understanding Subprocess much simpler! - Joerg Schad On June 3, 2015, 1:45 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35000/ > ----------------------------------------------------------- > > (Updated June 3, 2015, 1:45 p.m.) > > > Review request for mesos, Bernd Mathiske and Joerg Schad. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/subprocess.hpp 37cab7755d2890619b64e1ca09e0b7ad0e72cf76 > > Diff: https://reviews.apache.org/r/35000/diff/ > > > Testing > ------- > > make check > doxygen ../Doxyfile > > > Thanks, > > Benjamin Hindman > > --===============7546645883246067651==--