Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E9B4017B8C for ; Mon, 1 Jun 2015 21:26:50 +0000 (UTC) Received: (qmail 36263 invoked by uid 500); 1 Jun 2015 21:26:50 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 36241 invoked by uid 500); 1 Jun 2015 21:26:50 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 36226 invoked by uid 99); 1 Jun 2015 21:26:50 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Jun 2015 21:26:50 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B5C4E1DDE1D; Mon, 1 Jun 2015 21:26:48 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4514986191909407944==" MIME-Version: 1.0 Subject: Re: Review Request 30339: Call hookmanager only if some hooks are installed. From: "Kapil Arya" To: "Niklas Nielsen" , "Till Toenshoff" Cc: "Mesos ReviewBot" , "mesos" Date: Mon, 01 Jun 2015 21:26:48 -0000 Message-ID: <20150601212648.3245.40085@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Kapil Arya" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/30339/ X-Sender: "Kapil Arya" References: <20150128004206.25679.75381@reviews.apache.org> In-Reply-To: <20150128004206.25679.75381@reviews.apache.org> Reply-To: "Kapil Arya" X-ReviewRequest-Repository: mesos --===============4514986191909407944== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30339/ ----------------------------------------------------------- (Updated June 1, 2015, 5:26 p.m.) Review request for mesos, Niklas Nielsen and Till Toenshoff. Changes ------- Rebased and udpated. Summary (updated) ----------------- Call hookmanager only if some hooks are installed. Repository: mesos Description ------- Call hook manager only if hooks were specified on the commandline. Diffs (updated) ----- src/hook/manager.hpp 638e19f5062f070cd0ec94d830615a2c73fd357d src/hook/manager.cpp 54b0d34b6e9f2f8a8cf7a6c2f5ded2f6ab6c6955 src/master/master.cpp 710b8149c9d855d0f47cb2952366be10bc78c74d src/slave/containerizer/containerizer.cpp 4d66e767de1f877cb66b37826ba7c9d00639a7c0 src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05 src/tests/hook_tests.cpp 3ffde6d6b2faeb5a8a40eb27c3b0a2b7f9ecd2b1 Diff: https://reviews.apache.org/r/30339/diff/ Testing ------- make check Thanks, Kapil Arya --===============4514986191909407944==--