mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 32982: Added reservation user guide.
Date Fri, 26 Jun 2015 20:02:29 GMT


> On May 13, 2015, 11:16 p.m., Bernd Mathiske wrote:
> > docs/reservation.md, line 95
> > <https://reviews.apache.org/r/32982/diff/1/?file=921006#file921006line95>
> >
> >     This sentence does not strictly add any information. It is more likely confusing.
What does it mean to "convert" a resource? I suppose we are merely accounting for them here,
not physically affecting the resources themselves, right?
> >     
> >     Suggestion:
> >     
> >     The Mesos master will take the requested reservation into account.

I agree that this section doesn't actually add much value. I've simplified this section and
simply described the possible HTTP responses instead.


> On May 13, 2015, 11:16 p.m., Bernd Mathiske wrote:
> > docs/reservation.md, line 132
> > <https://reviews.apache.org/r/32982/diff/1/?file=921006#file921006line132>
> >
> >     Same as the above sentence.

Same here.


> On May 13, 2015, 11:16 p.m., Bernd Mathiske wrote:
> > docs/reservation.md, line 249
> > <https://reviews.apache.org/r/32982/diff/1/?file=921006#file921006line249>
> >
> >     Isn't this the exact same offer as above? Can we simply reference it instead
of repeating it?

It is indeed the exact same offer. I decided to keep it here since one of the things I learned
is that people don't read necessarily read from top to bottom. I have added a note saying
that they're the same, for those who are reading top to bottom.

```
A framework is able to unreserve resources through the resource offer cycle. In Offer::Operation::Reserve,
we reserved 8 CPUs and 4096 MB of RAM for our `role`. The master will continue to offer these
resources to our `role`. Suppose we would like to unreserve these resources.
First, we receive a resource offer like below:

/* repeated for those who are jumping sections. */
```


> On May 13, 2015, 11:16 p.m., Bernd Mathiske wrote:
> > docs/reservation.md, line 320
> > <https://reviews.apache.org/r/32982/diff/1/?file=921006#file921006line320>
> >
> >     Even if we repeat the offer from way above here, we may want to mention that
it is exactly the same again.

Agreed. Done.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review83678
-----------------------------------------------------------


On June 26, 2015, 7:53 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> -----------------------------------------------------------
> 
> (Updated June 26, 2015, 7:53 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2205
>     https://issues.apache.org/jira/browse/MESOS-2205
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/reservation.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32982/diff/
> 
> 
> Testing
> -------
> 
> Documentation.
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message