mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 35699: Added an invariant CHECK_EQ for available resources in HierarchicalAllocator::updateAllocation.
Date Wed, 24 Jun 2015 15:35:47 GMT


> On June 24, 2015, 12:44 a.m., Ben Mahler wrote:
> > src/master/allocator/mesos/hierarchical.hpp, lines 702-703
> > <https://reviews.apache.org/r/35699/diff/1/?file=988943#file988943line702>
> >
> >     Whoops, Jie just noticed that this isn't correct because 'updatedAllocation'
is for the framework only, whereas 'total' and 'available' are for all frameworks on the slave.

Yikes. Kudos to Jie for catching this. Sorry about that, I've followed-up on this at https://reviews.apache.org/r/35816/.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35699/#review89107
-----------------------------------------------------------


On June 20, 2015, 7:52 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35699/
> -----------------------------------------------------------
> 
> (Updated June 20, 2015, 7:52 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp 646ee8c1c0fb824e1d17150b4e96e6281c65358f

> 
> Diff: https://reviews.apache.org/r/35699/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message