mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 35717: Add reservations support to master's state.json
Date Wed, 24 Jun 2015 10:24:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/#review89146
-----------------------------------------------------------


Looks great! Just a couple of questions, but I think this is very close to shippable.


src/common/http.cpp (line 84)
<https://reviews.apache.org/r/35717/#comment141744>

    I wonder if you could templatize this to work for modeling any hashmap<string, T>,
where T is an already modeled type.



src/master/http.cpp (line 235)
<https://reviews.apache.org/r/35717/#comment141745>

    Since this is an API change, we may want to document that the "resources" field in state.json
now also includes persistent volumes (and dynamic reservations). This could be covered by
https://issues.apache.org/jira/browse/MESOS-2123



src/master/http.cpp (lines 236 - 239)
<https://reviews.apache.org/r/35717/#comment141748>

    I wonder if users would want to know about used vs. offered vs. available reserved resources,
or if they just want to know about the reservations in aggregate, no matter the current status
of those resources.
    I think we're probably fine just listing the resources by role, regardless of status.


- Adam B


On June 22, 2015, 4:37 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35717/
> -----------------------------------------------------------
> 
> (Updated June 22, 2015, 4:37 a.m.)
> 
> 
> Review request for mesos, Adam B and Michael Park.
> 
> 
> Bugs: MESOS-692
>     https://issues.apache.org/jira/browse/MESOS-692
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add reservations support to master's state.json
> 
> 
> Diffs
> -----
> 
>   src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8 
>   src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c 
>   src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e 
>   src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf 
> 
> Diff: https://reviews.apache.org/r/35717/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message