mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 35772: Made post-reviews.py print parent diff only if one exists.
Date Tue, 23 Jun 2015 07:50:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35772/#review88935
-----------------------------------------------------------

Ship it!


Ship It!

- Till Toenshoff


On June 23, 2015, 7:21 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35772/
> -----------------------------------------------------------
> 
> (Updated June 23, 2015, 7:21 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made the `... with parent diff created from:` show up only if such parent diff exists.
> 
> Before:
> ```
> Creating diff of:
> 4610aa02c07e90f9bf69ef0eb119c043ad95a116 - (HEAD, post-reviews) Made post-reviews.py
print parent diff only if one exists.
> 
> ... with parent diff created from:
> ```
> 
> After:
> ```
> Creating diff of:
> 4610aa02c07e90f9bf69ef0eb119c043ad95a116 - (HEAD, post-reviews) Made post-reviews.py
print parent diff only if one exists.
> ```
> 
> 
> Diffs
> -----
> 
>   support/post-reviews.py 10861a9eb9739a519732fef02a14dc4514463a8c 
> 
> Diff: https://reviews.apache.org/r/35772/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message