mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 35696: libprocess: Fixed test names.
Date Mon, 22 Jun 2015 19:28:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35696/#review88834
-----------------------------------------------------------

Ship it!


I'll get this committed for you, one other inconsistency is that some tests are "Process"
and some tests are named "JsonTest". The latter tends to be forced when we have a test fixture
(e.g. MasterTest).

- Ben Mahler


On June 20, 2015, 7:14 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35696/
> -----------------------------------------------------------
> 
> (Updated June 20, 2015, 7:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> First noticed `JsonTest.parse`, then found the other cases with the following regex:
`TEST.*(.*, [a-z].*`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/http_tests.cpp 86b2c7d3beae6671474cf0a5ad52a10334bc9230

>   3rdparty/libprocess/src/tests/io_tests.cpp 84e5d746220dfa274465632280de87dc5e7f673a

>   3rdparty/libprocess/src/tests/mutex_tests.cpp 451b234ca46dd91bff6d8463a00a40fb14070db6

>   3rdparty/libprocess/src/tests/process_tests.cpp 660af45e7fd45bdf5d43ad9aa54477fd94f87058

>   3rdparty/libprocess/src/tests/queue_tests.cpp 79741d37cb761593b38f21eef466d0313220d721

>   3rdparty/libprocess/src/tests/statistics_tests.cpp 0e4960a4e2e807ee9f3f6d83cdbfa6b563352760

>   3rdparty/libprocess/src/tests/timeseries_tests.cpp fd906b869e8bbf5c07c67c5319dec82681e811b7

> 
> Diff: https://reviews.apache.org/r/35696/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message