mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 34427: AppC provisioner backend using bind mounts.
Date Mon, 22 Jun 2015 18:32:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34427/#review88824
-----------------------------------------------------------


Bad patch!

Reviews applied: [34136, 34134, 34135]

Failed command: ./support/apply-review.sh -n -r 34135

Error:
 2015-06-22 18:32:03 URL:https://reviews.apache.org/r/34135/diff/raw/ [37213/37213] ->
"34135.patch" [1]
error: patch failed: src/slave/containerizer/mesos/containerizer.cpp:120
error: src/slave/containerizer/mesos/containerizer.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On June 22, 2015, 4:53 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34427/
> -----------------------------------------------------------
> 
> (Updated June 22, 2015, 4:53 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Note: This is a specialized backend; see notes in bind_backend.hpp.
>  
> Reproduced here for your convenience:
> 
> This is a specialized backend that may be useful for deployments
> using large (multi-GB) single-layer images *and* where more
> recent kernel features such as overlayfs are not available. For small
> images (10's to 100's of MB) the Copy backend may be sufficient.
> 1) It supports only a single layer. Multi-layer images will fail
>    to provision and the container will fail to launch!
> 2) The filesystem is read-only because all containers using this
>    image share the source. Select writable areas can be achieved
>    by
>    mounting read-write volumes to places like /tmp, /var/tmp,
>    /home, etc. using the ContainerInfo. These can be relative to
>    the executor work directory.
> 3) It relies on the image persisting in the store.
> 4) It's fast because the bind mount requires (nearly) zero IO.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am e7de0f3d1a5efeaef47d5074defe3b40db94f573 
>   src/slave/containerizer/provisioners/appc/backend.cpp PRE-CREATION 
>   src/slave/containerizer/provisioners/appc/bind_backend.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34427/diff/
> 
> 
> Testing
> -------
> 
> manual testing of a single layer image with RW relative bind mount for /tmp.
> 
> 
> Thanks,
> 
> Ian Downes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message