mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 35433: Send StatusUpdates if checkpointed resources don't exist on the slave.
Date Thu, 18 Jun 2015 17:27:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35433/#review88406
-----------------------------------------------------------



src/slave/slave.cpp (lines 1403 - 1421)
<https://reviews.apache.org/r/35433/#comment140916>

    Hum, are you sending multiple status update if there are multiple 'resource's in 'checkpointedTaskResources'?



src/slave/slave.cpp (line 1409)
<https://reviews.apache.org/r/35433/#comment140915>

    Have we decided to not capture temp variable by const ref? Maybe you want to do a sweep
to fix that in this file?



src/slave/slave.cpp (lines 1428 - 1450)
<https://reviews.apache.org/r/35433/#comment140917>

    Ditto here.


- Jie Yu


On June 18, 2015, 5:05 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35433/
> -----------------------------------------------------------
> 
> (Updated June 18, 2015, 5:05 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> No bug was observed (yet), but realized I forgot about this in the dynamic reservations
patches.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp a5ad29f59fadba919ed82ba2892c2febe551660b 
> 
> Diff: https://reviews.apache.org/r/35433/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message